MFCMAPI Work Item Rss Feed

Closed Task: Sort List Shutdown Spends a Long Time Deleting Columns [9166]

sgriffin — Tue, 17 Nov 2009 16:54:10 GMT

Problem: Noticed during debug we spent a lot of cycles in DeleteAllColumns.
Fix: We don't have any specific need to delete the columns. Better to leave them alone and let the control handle the deletion. Presumably the control will be more efficient than manually deleting column by column. Created flag to signal the deletion is happening during shutdown and if so just handle my own memory cleanup.

Closed Task: People Keep Running Wrong Version of MFCMAPI [9156]

sgriffin — Tue, 17 Nov 2009 16:54:08 GMT

Problem: People keep pulling the 64 bit build even though they do not have 64 bit MAPI.
Fix: Can't make people not stupid, but can rework the error dialog to be clearer that they have been stupid. Wrong version error is now customized for 64 and 32 bit builds.

Closed Feature: Smart View is Wicked Cool, but Can I Turn it Off? [9155]

sgriffin — Tue, 17 Nov 2009 16:54:08 GMT

Problem: Any bug in Smart View parsing can make MFCMAPI crash whenever the props are looked at, making it unusable.
Fix: Add an option to turn the parsing off to mitigate problems after someone discovers a smart view parsing bug.

Closed Task: Smart View Column on Non-Smart View MV Props [9154]

sgriffin — Tue, 17 Nov 2009 16:54:07 GMT

Problem: Most MV props do not have smart view parsing, but this column showed anyway.
Fix: Only display the column for long and binary types.

Closed Task: Can't Manually Edit CRLF in Properties [9153]

sgriffin — Tue, 17 Nov 2009 16:54:05 GMT

Problem: Occasionally, we need fine control over the number/location of CR and LF (0xD, 0xA) in a string property. Rich Edit control canonicalizes line endings, eliminating this kind of control.
Fix: Can't fix the Rich Edit control, but can make sure that if we edit the binary version of the text that this change is kept. Key is not reading final value from the rich edit control but instead reading it from the hex.

Closed Issue: PropTagEditor Can't Do Named Prop Lookup [9152]

sgriffin — Tue, 17 Nov 2009 16:54:04 GMT

Problem: Opening the dialog and filling out named prop information never got a prop ID.
Fix: This was a bug in my new caching code - CacheGetIDsFromNames was returning the lookup up value in the wrong format. This was the only case that actually hit this lookup.

Closed Task: DisplayObject Dialog Confuses People [9151]

sgriffin — Tue, 17 Nov 2009 16:54:02 GMT

Problem: Even though it's just informational and not an error, keep getting error reports when people display it.
Fix: Cut it. Replace it with debug spew.

Closed Issue: Smart View Crash Handling Large Security Descriptor [9150]

sgriffin — Tue, 17 Nov 2009 16:54:00 GMT

Problem: Large security descriptors tripped a problem FormatMessage has with large strings.
Fix: Massage code not to pass potentially large strings to FormatMessage and instead concatenate them manually.

Closed Feature: OpenStreamOnFileW Not Implemented [9148]

sgriffin — Tue, 17 Nov 2009 16:53:59 GMT

Problem: Outlook just documented this cool function: http://blogs.msdn.com/stephen_griffin/archive/2009/09/29/openstreamonfile-vs-unicode-files.aspx
Fix: Import it, use it in the file dialog Unicode change. Make sure wrapper function, MyOpenStreamOnFile, properly handles case when function is not available.

Closed Task: New/Missing Props [9147]

sgriffin — Tue, 17 Nov 2009 16:53:59 GMT

Problem: Tweaking our prop set. PidTagScheduleInfoDelegateNamesW should be MV_UNICODE. PR_ASSOCIATED_SHARING_PROVIDER was missing.
Fix: Fix it.

Closed Issue: NULL parent Dialog Clicking Up/Down In Messages [9146]

sgriffin — Tue, 17 Nov 2009 16:53:58 GMT

Problem: When using the form viewer to look at messages on an Outlook box, clicking the up/down button on the message to move to the next/previous message pops a dialog:
"Form Viewer created with a NULL parent!"
This is fallout from my work to ensure windows were properly parented. This dialog was left in to identify missed cases. Problem was OpenMessageNonModal had no way to pass in an HWND for a parent, so we always had to guess. Opening a message and hitting next message got us into a situation where we could not guess.
Fix: Add an HWND parameter to OpenMessageNonModal and use it.

Closed Issue: Smart View Parsing for MV Binary Props Gets Confused [9145]

sgriffin — Tue, 17 Nov 2009 16:53:56 GMT

Problem: The hack I put in for parsing MV props last time got confused if we had parsing for two props with the same id, but one was MV and the other wasn't.
Fix: Broke the Smart View parsing logic out of InterpretProp - it's out of the SmartView business. Introduced new function, InterpretPropSmartView, to handle SV parsing. New function takes a BOOL to signal if the prop being parsed a row from a MV prop. Added new column to BINARY_STRUCTURE_ARRAY_ENTRY to note whether the structure was an MV prop or not. All this gives us enough information to pick the right parser.

Closed Issue: Aborting Table Load Expensive and Slow [9144]

sgriffin — Tue, 17 Nov 2009 16:53:55 GMT

Problem: Thread synchronization was poorly handled, using SendMessage to check if we should abort thread load in DwThreadFuncLoadTable.
Fix: Use proper sync logic so we can check a flag for abort, avoiding the SendMessage call. Since the check is much cheaper now, fixed the code to check more often, making the abort more responsive. Also simplified the wait for shutdown loop in OnCancelTableLoad, as part of the code cleanup to fix the message swallowing issue that broke Close All.

Closed Issue: Context Menus on Wrong Screen [9143]

sgriffin — Tue, 17 Nov 2009 16:53:54 GMT

Problem: On multimon, conext menus were showing on the default monitor, not the screen where they were triggered.
Fix: There's some voodoo I don't quite get in parsing the lparam for WM_CONTEXTMENU. Fortunately, we can override OnContextMenu and use the passed in pos, which has been corrected for multimon.

Closed Issue: File Picker Treats Unicode Characters as ? [9142]

sgriffin — Tue, 17 Nov 2009 16:53:53 GMT

Problem: We're using the MFC CFileDialog class to select files. This class is ANSI only in non-unicode builds.
Fix: Abandon CFileDialog and my child class CFileDialogEx and reimplement it so we can choose ANSI or UNICODE flavors. Introduce CFileDialogExA/CFileDialogExW and macro CFileDialogEx which behaves like the old class. Reimplementation takes only the core of what we need from CFileDialog. Duplicate implementations for now - will later look at implementing CFileDialogExA as a wrapper around CFileDialogExW.

Had to chase a number of file handling routines through the code and convert them to Unicode. Note, in particular, wholesale changes to file.cpp.

Closed Issue: Error Viewing Non Embedded Attachments [9141]

sgriffin — Tue, 17 Nov 2009 16:53:52 GMT

Problem: When the option is selected to view embedded message attachments as messages, selecting a regular attachment throws an error.
Fix: Check for ATTACH_EMBEDDED_MSG and only attempt to open the PR_ATTACH_DATA_OBJ if this flag is set.

Closed Issue: New Windows Center on Wrong Screen [9140]

sgriffin — Tue, 17 Nov 2009 16:53:51 GMT

Problem: With multimon, we're seeing our new windows show up only on the default monitor. They should appear on the same screen as the previous window.
Fix: Override CheckAutoCenter to provide my own centering logic.

Closed Task: CCH/CCHW Should be Replaced by _countof [9139]

sgriffin — Tue, 17 Nov 2009 16:53:50 GMT

Problem: Hand rolled CCH/CCHW macros are finicky and dangerous.
Fix: Replace with built in _countof macro.

Closed Task: Eliminate use of strsafe [7786]

sgriffin — Tue, 17 Nov 2009 16:53:50 GMT

last update of strsafe header raised warnings not to use strsafe anymore. Need to remove the header and scrub out references.

Closed Task: RES_COUNT Handling May Not be Correct [7785]

sgriffin — Tue, 17 Nov 2009 16:53:48 GMT

During code review, had some questions about how I handle this type - need to dig into the code and see if it's correct